This repository has been archived by the owner on Dec 14, 2019. It is now read-only.
Fixed G510 keyboard module #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for creating this PR. I hope I'll get some time to test it during the holidays |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous hid-g510.c file was purely based on g13 driver but G510 does not have the same USB reports as g13. In this version I fixed the driver and now it is able to change keyboard background color and set the led of M keys. But using with gnome15 is not working but it seems that some work is needed on driver_kernel.py. I will continue to work to get the driver working with gnome15, but want to share what I have so far.
By the way, changed a bit hid-gcore to check for null pointers. If, for some reason, the probe fails, it would generate a null pointer exception during disconnect. With these checks in place, this does not happen.